BLFS "X Window Environment" and "Xorg"

[Randy McMurchy]

Preface:

"This chapter contains a graphical user environment."

Perhaps this should be changed since the addition of the 
X-org package to something like: "This chapter contains
packages allowing you to install a graphical user
environment."

===================
Xorg:

1. "In fact the base system of Xorg is XFree86-RC2."

Purely optional, a comma after "In fact" is normally used.

2. "XFree86 continues to be a solid, conservitive application"

s/conservitive/conservative/

3. "and the desktop environment while also providing"

Perhaps a comma after "environment".

4. "The first package contains the Xorg libraries"

s/package/file/

5. "All seven packages should give an OK status."

s/packages/files/

(I suppose #'s 4 and 5 are just my personal preference. To me,
the 7 files all combine to make the Xorg package.)

6. "If you have an Intel P6 (Pentium Pro, Pentium II and later)
it is recommended"

Perhaps a comma after the parenthetical text.

7. "Cyrix and AMD CPUs to the MTRR interface so selecting this

Perhaps a comma after "interface".

8. "When building Xorg you should create a shadow"

Purely optional, a comma after "Xorg" sounds better.

9. "The documentation for Xorg indicates that the application
will build without a host.def file, but the included libraries
for fontconfig and freetype2 do not build properly on a base
LFS system so we must specify that we have those and some other
libraries too."

Quite a sentence (also includes "we"). Perhaps breaking it up
with: "base LFS system. Therefore, you must specifiy that those
libraries, as well as some others, are system included.

10. "Be sure to make sure the comments"

Reduntant wording. Perhaps "Ensure the comments".

11. "the same location as normal output."

s/normal output/stdout/  or  s/normal output/standard output/

12. "parentheses around the command run the entire comand"

s/run/runs/

13. "though the i Filesystem Hierarchy Standard"

I'm not sure what the "i" is in there for.

14. "Edit /etc/ld.so.conf and add /usr/X11R6/lib. Run"

Perhaps a semicolon after "Run".

15. "Add the following line to .bash_profile for root user:"

Two things here: One, it should probably be "the root user",
and two, my personal opinion is it should be included in the
system wide profile. Here's why:

It's mentioned in the LFS book, and other respected sources
that building packages as root is discouraged. Only for the
actual "make install" or other root-required steps should
installation procedures be accomplished by root. Therefore,
if someone is following careful procedure and building as
a normal user, PKG_CONFIG_PATH needs to be updated for that
user as well.

Personal preference, of course. However, I don't see any
harm in expanding the system-wide PKG_CONFIG_PATH.

16. There's a one-word line right after the PKG_CONFIG_PATH
stuff that should probably have a semicolon after it. This
follows by sourcing ~/.bash_profile. If step 15 was changed
to modify the system-wide profile, this command would have
to be changed as well.

I realize it's picky, but top-to-bottom installation of
packages by the root user is just plain asking for trouble.

17. Not sure what to think about the ln -s psaux /dev/mouse
command. As I pointed out in an earlier message, the BLFS
GPM instructions says doing this is a "bad thing". It 
doesn't matter to me, it just doesn't present a consistent
message to readers.

18. "Start X with"

Perhaps a semicolon at the end.

19. "to get basic functional X Window System"

Perhaps insert an "a" before "basic".

-- 
Randy